-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax googleauth versions #333
Conversation
kubernetes-deploy.gemspec
Outdated
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec| | |||
spec.required_ruby_version = '>= 2.3.0' | |||
spec.add_dependency "activesupport", ">= 5.0" | |||
spec.add_dependency "kubeclient", "~> 3.0" | |||
spec.add_dependency "googleauth", "= 0.6.2" # https://github.com/google/google-auth-library-ruby/issues/153 | |||
spec.add_dependency "googleauth", "~> 0.6.4" # https://github.com/google/google-auth-library-ruby/issues/153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do "~> 0.6", ">= 0.6.4"
to allow minor version upgrades?
@stefanmb any reason this stalled? |
Bumping the version caused test failures, haven't had a chance to investigate. Downgrading my dependency unblocked me. |
@@ -14,7 +14,7 @@ def teardown | |||
def test_auth_use_default_gcp_success | |||
config = KubernetesDeploy::KubeclientBuilder::GoogleFriendlyConfig.new(kubeconfig, "") | |||
|
|||
stub_request(:post, 'https://www.googleapis.com/oauth2/v4/token') | |||
stub_request(:post, 'https://oauth2.googleapis.com/token') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a legitimate change introduced by googleapis/google-auth-library-ruby#147.
Note that there isn't much in the way of docs in that PR, and the old version we used (0.6.2) has no tag associated with it.
The underlying issue googleapis/google-auth-library-ruby#153 was resolved and released in
0.6.4
https://github.com/googleapis/google-auth-library-ruby/pull/154/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR3.